Review and Rating Application issueshttps://code.sigsiu.net/Sigsiu.NET/ReviewRating/-/issues2017-10-31T15:18:57Zhttps://code.sigsiu.net/Sigsiu.NET/ReviewRating/-/issues/3can't delete review2017-10-31T15:18:57ZSławek Sikoracan't delete reviewWhen I try to delete review from the back-end, there appear following error:<br />
0 Call to a member function get() on nullWhen I try to delete review from the back-end, there appear following error:<br />
0 Call to a member function get() on null2.3Sigrid SuskiSigrid Suskihttps://code.sigsiu.net/Sigsiu.NET/ReviewRating/-/issues/2Not approved reviews are count in the Top rated view2017-10-31T15:21:35ZSławek SikoraNot approved reviews are count in the Top rated viewRatings from the reviews which aren't yet approved are counted to in the Top Rated view. In the results entries can be are ordered by ratings values which aren't approved and visible in the entry details.Ratings from the reviews which aren't yet approved are counted to in the Top Rated view. In the results entries can be are ordered by ratings values which aren't approved and visible in the entry details.2.3Sigrid SuskiSigrid Suskihttps://code.sigsiu.net/Sigsiu.NET/ReviewRating/-/issues/1problems with higher pagination numbers2018-02-14T15:46:52ZSławek Sikoraproblems with higher pagination numbersWhen there are more than 10 pagination sites, load more reviews button disappear on 2nd pagination site.
<br /><br />
I'm not sure why but in the review navigation script test:<br />
if ( this.site >= this.sites ) <br />
return true when site is 2 and sites is 11 or more<br /><br />
I'm not sure if this is correct solution but for me works following: In the review.js file replace lines 327-329:<br />
```
this.finish = function ( data )
{
if ( this.site >= this.sites ) {
```
with:
```
this.finish = function ( data )
{
var site = +(this.site);
var sites = +(this.sites);
if ( site >= sites ) {
```When there are more than 10 pagination sites, load more reviews button disappear on 2nd pagination site.
<br /><br />
I'm not sure why but in the review navigation script test:<br />
if ( this.site >= this.sites ) <br />
return true when site is 2 and sites is 11 or more<br /><br />
I'm not sure if this is correct solution but for me works following: In the review.js file replace lines 327-329:<br />
```
this.finish = function ( data )
{
if ( this.site >= this.sites ) {
```
with:
```
this.finish = function ( data )
{
var site = +(this.site);
var sites = +(this.sites);
if ( site >= sites ) {
```2.3Sigrid SuskiSigrid Suskihttps://code.sigsiu.net/Sigsiu.NET/ReviewRating/-/issues/5Missed notification text at review approve2022-05-12T12:56:09ZSławek SikoraMissed notification text at review approveI'm not sure if this report should be raised here or in the notification application project, but when review is approved and by administrator in the back-end, and notifications for approving reviews are enabled, there appear NOTA.STATUS_EMAIL_SENT constant text instead of the translated value.<br />
It looks like this constant isn't loaded from the en-GB.SpApp.notifications.ini file, but it search for it in the en-GB.SpApp.review_rating.ini, because when I put there string:<br />
`SP.NOTA.STATUS_EMAIL_SENT = "Email sent to %s %s." `
<br /> text is displayed correctly.I'm not sure if this report should be raised here or in the notification application project, but when review is approved and by administrator in the back-end, and notifications for approving reviews are enabled, there appear NOTA.STATUS_EMAIL_SENT constant text instead of the translated value.<br />
It looks like this constant isn't loaded from the en-GB.SpApp.notifications.ini file, but it search for it in the en-GB.SpApp.review_rating.ini, because when I put there string:<br />
`SP.NOTA.STATUS_EMAIL_SENT = "Email sent to %s %s." `
<br /> text is displayed correctly.https://code.sigsiu.net/Sigsiu.NET/ReviewRating/-/issues/13Fatal error with PHP 82022-11-18T11:39:16ZSławek SikoraFatal error with PHP 8Looks like latest version (3.0.0.4) cause fatal error with PHP 8:
```
Compile Error: Unparenthesized `a ? b : c ? d : e` is not supported. Use either `(a ? b : c) ? d : e` or `a ? b : (c ? d : e)`
at /home/sikorasobipro/test3.sikora.sobipro.eu/components/com_sobipro/lib/models/review.php:382
```Looks like latest version (3.0.0.4) cause fatal error with PHP 8:
```
Compile Error: Unparenthesized `a ? b : c ? d : e` is not supported. Use either `(a ? b : c) ? d : e` or `a ? b : (c ? d : e)`
at /home/sikorasobipro/test3.sikora.sobipro.eu/components/com_sobipro/lib/models/review.php:382
```3.0 BetaSigrid SuskiSigrid Suskihttps://code.sigsiu.net/Sigsiu.NET/ReviewRating/-/issues/12Rating form do not appear when reviews are disabled2022-11-18T11:39:21ZSławek SikoraRating form do not appear when reviews are disabledLike in the title, when reviews are disabled and only rating form should appear there appear following error:
```
Uncaught TypeError: modalReview.querySelector(...) is null
spReviewResetForm https://test3.sikora.sobipro.eu/components/com_sobipro/lib/js/opt/review.js:20
spReviewButton https://test3.sikora.sobipro.eu/components/com_sobipro/lib/js/opt/review.js:20
spReviewButton https://test3.sikora.sobipro.eu/components/com_sobipro/lib/js/opt/review.js:20
spReviewInitialise https://test3.sikora.sobipro.eu/components/com_sobipro/lib/js/opt/review.js:20
<anonymous> https://test3.sikora.sobipro.eu/components/com_sobipro/lib/js/opt/review.js:20
Ready https://test3.sikora.sobipro.eu/components/com_sobipro/lib/js/core.js:21
<anonymous> https://test3.sikora.sobipro.eu/components/com_sobipro/lib/js/opt/review.js:20
review.js:20:450
```Like in the title, when reviews are disabled and only rating form should appear there appear following error:
```
Uncaught TypeError: modalReview.querySelector(...) is null
spReviewResetForm https://test3.sikora.sobipro.eu/components/com_sobipro/lib/js/opt/review.js:20
spReviewButton https://test3.sikora.sobipro.eu/components/com_sobipro/lib/js/opt/review.js:20
spReviewButton https://test3.sikora.sobipro.eu/components/com_sobipro/lib/js/opt/review.js:20
spReviewInitialise https://test3.sikora.sobipro.eu/components/com_sobipro/lib/js/opt/review.js:20
<anonymous> https://test3.sikora.sobipro.eu/components/com_sobipro/lib/js/opt/review.js:20
Ready https://test3.sikora.sobipro.eu/components/com_sobipro/lib/js/core.js:21
<anonymous> https://test3.sikora.sobipro.eu/components/com_sobipro/lib/js/opt/review.js:20
review.js:20:450
```3.0 BetaSigrid SuskiSigrid Suskihttps://code.sigsiu.net/Sigsiu.NET/ReviewRating/-/issues/11Can't edit own reviews on the front-end when anonymous rating is disabled2022-11-18T11:39:27ZSławek SikoraCan't edit own reviews on the front-end when anonymous rating is disabledTrying to edit own review from the front-end generate following error:
` 0 Incorrect double value: '' for column `sikorasobipro_test3`.`osrs4_sobipro_sprr_review`.`oar` at row 1
- Call stack
- # Function Location
- 1 () JROOT/libraries/sobi/Application/Joomla/Database/MySQLi.php:1115
- 2 Sobi\Application\Joomla\Database\MySQLi->exec() JROOT/libraries/sobi/Application/Joomla/Database/MySQLi.php:689
- 3 Sobi\Application\Joomla\Database\MySQLi->update() JROOT/components/com_sobipro/lib/models/review.php:875
- 4 SPReview->saveReview() JROOT/components/com_sobipro/lib/ctrl/review.php:297
- 5 SPRevRatingCtrl->submit() JROOT/components/com_sobipro/lib/ctrl/review.php:65
- 6 SPRevRatingCtrl->execute() JROOT/components/com_sobipro/lib/ctrl/sobipro.php:574
- 7 SobiProCtrl->execute() JROOT/components/com_sobipro/sobipro.php:55
- 8 require_once() JROOT/libraries/src/Dispatcher/LegacyComponentDispatcher.php:69
- 9 Joomla\CMS\Dispatcher\LegacyComponentDispatcher::Joomla\CMS\Dispatcher\{closure}() JROOT/libraries/src/Dispatcher/LegacyComponentDispatcher.php:71
- 10 Joomla\CMS\Dispatcher\LegacyComponentDispatcher->dispatch() JROOT/libraries/src/Component/ComponentHelper.php:389
- 11 Joomla\CMS\Component\ComponentHelper::renderComponent() JROOT/libraries/src/Application/SiteApplication.php:204
- 12 Joomla\CMS\Application\SiteApplication->dispatch() JROOT/libraries/src/Application/SiteApplication.php:243
- 13 Joomla\CMS\Application\SiteApplication->doExecute() JROOT/libraries/src/Application/CMSApplication.php:278
- 14 Joomla\CMS\Application\CMSApplication->execute() JROOT/includes/app.php:63
- 15 require_once() JROOT/index.php:32 `
This problem happens only when anonymous rating is disabled, seems like this function treat logged in user same as visitor.Trying to edit own review from the front-end generate following error:
` 0 Incorrect double value: '' for column `sikorasobipro_test3`.`osrs4_sobipro_sprr_review`.`oar` at row 1
- Call stack
- # Function Location
- 1 () JROOT/libraries/sobi/Application/Joomla/Database/MySQLi.php:1115
- 2 Sobi\Application\Joomla\Database\MySQLi->exec() JROOT/libraries/sobi/Application/Joomla/Database/MySQLi.php:689
- 3 Sobi\Application\Joomla\Database\MySQLi->update() JROOT/components/com_sobipro/lib/models/review.php:875
- 4 SPReview->saveReview() JROOT/components/com_sobipro/lib/ctrl/review.php:297
- 5 SPRevRatingCtrl->submit() JROOT/components/com_sobipro/lib/ctrl/review.php:65
- 6 SPRevRatingCtrl->execute() JROOT/components/com_sobipro/lib/ctrl/sobipro.php:574
- 7 SobiProCtrl->execute() JROOT/components/com_sobipro/sobipro.php:55
- 8 require_once() JROOT/libraries/src/Dispatcher/LegacyComponentDispatcher.php:69
- 9 Joomla\CMS\Dispatcher\LegacyComponentDispatcher::Joomla\CMS\Dispatcher\{closure}() JROOT/libraries/src/Dispatcher/LegacyComponentDispatcher.php:71
- 10 Joomla\CMS\Dispatcher\LegacyComponentDispatcher->dispatch() JROOT/libraries/src/Component/ComponentHelper.php:389
- 11 Joomla\CMS\Component\ComponentHelper::renderComponent() JROOT/libraries/src/Application/SiteApplication.php:204
- 12 Joomla\CMS\Application\SiteApplication->dispatch() JROOT/libraries/src/Application/SiteApplication.php:243
- 13 Joomla\CMS\Application\SiteApplication->doExecute() JROOT/libraries/src/Application/CMSApplication.php:278
- 14 Joomla\CMS\Application\CMSApplication->execute() JROOT/includes/app.php:63
- 15 require_once() JROOT/index.php:32 `
This problem happens only when anonymous rating is disabled, seems like this function treat logged in user same as visitor.3.0 BetaSigrid SuskiSigrid Suskihttps://code.sigsiu.net/Sigsiu.NET/ReviewRating/-/issues/10Approve icon always show unapproved2022-11-18T11:39:33ZSławek SikoraApprove icon always show unapprovedIn the "All reviews and ratings" view, approval column always show 'unapproved; icon, no matter if entry is approved or not. In the review details publishing tab, correct option is selected.In the "All reviews and ratings" view, approval column always show 'unapproved; icon, no matter if entry is approved or not. In the review details publishing tab, correct option is selected.3.0 BetaSigrid SuskiSigrid Suskihttps://code.sigsiu.net/Sigsiu.NET/ReviewRating/-/issues/9Review can't be edited when multiple reviews are disabled2022-11-18T11:39:39ZSławek SikoraReview can't be edited when multiple reviews are disabledWhen Multiple Reviews option is disabled user can't edit or delete own reviews. Edit button appear at the review, but after clicking it form doesn't appear.When Multiple Reviews option is disabled user can't edit or delete own reviews. Edit button appear at the review, but after clicking it form doesn't appear.3.0 BetaSigrid SuskiSigrid Suskihttps://code.sigsiu.net/Sigsiu.NET/ReviewRating/-/issues/8Approving ratings2022-11-18T11:39:45ZSławek SikoraApproving ratingsThis problem happens only when adding reviews is disabled in the review application configuration. In case if we do not have selected approve own permission and we add rating, specific ratings values are saved but aren't approved. In the result only overall rating value is passed to the front-end, and specific values for each ratings are missed.This problem happens only when adding reviews is disabled in the review application configuration. In case if we do not have selected approve own permission and we add rating, specific ratings values are saved but aren't approved. In the result only overall rating value is passed to the front-end, and specific values for each ratings are missed.3.0 BetaSigrid SuskiSigrid Suskihttps://code.sigsiu.net/Sigsiu.NET/ReviewRating/-/issues/6review.css file isn't loaded in the listing views2022-11-18T11:39:57ZSławek Sikorareview.css file isn't loaded in the listing viewsLike in the title, review.css file isn't loaded in the listing views. <br /><br />
As a workaround it can be added to the css_files key in the config.ini template file and eventual views ini files if they exist.Like in the title, review.css file isn't loaded in the listing views. <br /><br />
As a workaround it can be added to the css_files key in the config.ini template file and eventual views ini files if they exist.2.4Sigrid SuskiSigrid Suskihttps://code.sigsiu.net/Sigsiu.NET/ReviewRating/-/issues/4Notice in Entries Module when R&R application is enabled2022-11-18T11:40:03ZSławek SikoraNotice in Entries Module when R&R application is enabledI'm not sure if this is related to the entries module, review application or core/header plugin, however when section have enabled review application and entries module use Static engline, following notice appear:<br />
`Notice: json://{"section":"add_css_file","message":"File \/home\/sikorasobipro\/test2.sikora.sobipro.eu\/media\/sobipro\/css\/review.css does not exist.","code":0,"file":"SPHeader","line":519,"content":"In file SPHeader at line 519"} in /home/sikorasobipro/test2.sikora.sobipro.eu/components/com_sobipro/lib/sobi.php on line 107`
<br />Looks like from some reason header plugin try to load review.css file from it old locationI'm not sure if this is related to the entries module, review application or core/header plugin, however when section have enabled review application and entries module use Static engline, following notice appear:<br />
`Notice: json://{"section":"add_css_file","message":"File \/home\/sikorasobipro\/test2.sikora.sobipro.eu\/media\/sobipro\/css\/review.css does not exist.","code":0,"file":"SPHeader","line":519,"content":"In file SPHeader at line 519"} in /home/sikorasobipro/test2.sikora.sobipro.eu/components/com_sobipro/lib/sobi.php on line 107`
<br />Looks like from some reason header plugin try to load review.css file from it old location2.4Sigrid SuskiSigrid Suski