Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
R Review and Rating Application
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • External wiki
    • External wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Sigsiu.NET GmbH
  • Review and Rating Application
  • Issues
  • #1

Something went wrong while setting issue due date.
Closed
Open
Created 8 years ago by Sławek Sikora@SikorReporter
  • New issue

  • Report abuse

  • New issue

  • Report abuse

problems with higher pagination numbers

Closed

problems with higher pagination numbers

When there are more than 10 pagination sites, load more reviews button disappear on 2nd pagination site.

I'm not sure why but in the review navigation script test:
if ( this.site >= this.sites )
return true when site is 2 and sites is 11 or more

I'm not sure if this is correct solution but for me works following: In the review.js file replace lines 327-329:

	this.finish = function ( data )   
	{   
		if ( this.site >= this.sites ) { 

with:

	this.finish = function ( data )
	{
		
		var site = +(this.site);
		var sites = +(this.sites);
		if ( site >= sites ) {
  1. Oh no!

    You are trying to upload something other than an image. Please upload a .png, .jpg, .jpeg, .gif, .bmp, .tiff or .ico.

    Incoming!

    Drop your designs to start your upload.

Linked issues
...

    Related merge requests

    • Sigrid Suski @TrinitySu changed title from problems with greater pagination numbers to problems with higher pagination numbers 8 years ago

      changed title from problems with greater pagination numbers to problems with higher pagination numbers

    • Sigrid Suski @TrinitySu added bug new labels 8 years ago

      added bug new labels

    • Sigrid Suski @TrinitySu changed milestone to %2.3 8 years ago

      changed milestone to %2.3

    • Sigrid Suski @TrinitySu assigned to @Trinity 7 years ago

      assigned to @Trinity

    • Sigrid Suski @TrinitySu added Review & Rating fixed in vc and removed new labels 7 years ago

      added Review & Rating fixed in vc and removed new labels

    • Sławek Sikora
      Sławek Sikora @Sikor · 7 years ago
      Reporter

      tested

    • Sławek Sikora @Sikor added test passed and removed fixed in vc labels 7 years ago

      added test passed and removed fixed in vc labels

    • Sigrid Suski @TrinitySu closed 7 years ago

      closed

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    Sigrid Suski's avatar
    Sigrid Suski
    @TrinitySu
    Assign to
    2.3
    Milestone
    2.3 (Past due)
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    Due date
    None
    None
    3
    Labels
    Review & Rating bug test passed
    Assign labels
    • No matching results
    • Manage project labels
    Confidentiality
    Not confidential
    Not confidential

    You are going to turn on confidentiality. Only team members with at least Reporter access will be able to see and leave comments on the issue.

    Lock issue
    Unlocked
    2
    2 participants
    user avatar
    user avatar
    Reference:

    footer

    Legal Notice / Impressum | Data Protection / Datenschutzinformation